Attention is currently required from: daniel, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email )
Change subject: vlr: Add support for CS and PS timers
......................................................................
Patch Set 3:
(2 comments)
File src/libmsc/msc_vty.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/7d72c3b5_5757f738?usp… :
PS2, Line 1052: T3212
"%s", vlr_is_cs(vsub->vlr) ?
"T3212" : "T3312"
Done
File src/libvlr/vlr_lu_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/2453b31a_321c6e77?usp… :
PS2, Line 449: osmo_tdef_fsm_inst_state_chg(fi, LU_COMPL_VLR_S_WAIT_TMSI_CNF,
lu_compl_fsm_state_tdef, vlr_tdefs, 6);
The 6 should never trigger because there is always a
timer in the tdef. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I364973b8d9e277ec5963343c0a83061e81a5baba
Gerrit-Change-Number: 38486
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Jan 2025 18:34:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>