Attention is currently required from: fixeria, osmith.
keith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40965?usp=email )
Change subject: OBS: --version-append: never override version ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ci/+/40965/comment/7233975f_9562c18b?usp=e... : PS1, Line 25: While IMHO it is a bad idea to just amend the commit of the last release
yes, but on their own branch, not master.
I think what I did there was checkout the latest tag, then git rebase -i [quite_some_commits back] and delete the commits relating to running as osmocom user. Anyway, it doesn't matter. All I'll say is don't make this change on my account, as I understand better now how it works, I'm fine with it.
I cannot speak to whether or not it is a good idea in general.