Attention is currently required from: fixeria, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30616 )
Change subject: ipa: Add ipa_client_conn_open2 with connect timeout argument ......................................................................
Patch Set 3:
(2 comments)
File include/osmocom/abis/ipa.h:
https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/f6f6a7d0_185d2d35 PS3, Line 108: int ipa_client_conn_open2(struct ipa_client_conn *link, int connect_timeout); unsigned int connect_timeout
File src/input/ipa.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/6eee0b64_ea82f987 PS2, Line 136: osmo_timer_del(&link->timer);
That's also called in ipa_conn_client_close() which is called from ipa_connect_failure() […]
Ah I see, better add a comment innside the if block above, soemthing like "/* link->timer is deleted when closing the conn) */"