Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39881?usp=email )
Change subject: s1gw: ConnHdlr: allow passing {MME,ENB}-UE-S1AP-ID
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
I'm not following this in detail, but my gut feeling tells me it might have been
preferable to encapsulate all those extra function arguments in a per-UE component and
then use that component instead of the eNB globsl ConnHdlr? this way more convenience and
less explicit function arguments...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39881?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ife37c77cff348cdfbde191dbad6da816e68ca941
Gerrit-Change-Number: 39881
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Apr 2025 05:59:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes