Attention is currently required from: pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32128 )
Change subject: rtp continuous-streaming: fix BFI in the quality-suppressed case ......................................................................
Patch Set 1:
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32128/comment/21db46c9_17b5bd58 PS1, Line 1661: send_ul_rtp_packet(lchan, fn, bfi, 0);
bfi is actually not used here (len=0), so better pass NULL to make it clear.
I did not realize that passing a NULL pointer was allowed, for some reason I thought it had to be a pointer to some "real" memory location, like what happens with msg->data when msg->len equals 0. But if you say that NULL is acceptable, then of course it is philosophically more correct - I'll spin a revised patch.