Attention is currently required from: laforge, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41921?usp=email )
Change subject: core: remove SCTP include from osmo_io_internal.h
......................................................................
Patch Set 2:
(1 comment)
File src/core/osmo_io_internal.h:
https://gerrit.osmocom.org/c/libosmocore/+/41921/comment/1bc1555e_69e27ff0?u... :
PS1, Line 10: #include <netinet/sctp.h>
AFAICT this include is not really used in this header, so you can change this patch to simply remove […]
You're right, the header itself does not use it directly.
I've removed the include, but kept config.h
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/41921?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icd626d908192a954d55d76a46d7cc863ed332631
Gerrit-Change-Number: 41921
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov
dtv.comp@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Sun, 25 Jan 2026 18:54:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de