Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40263?usp=email )
Change subject: cnlink: Fix several funcs missing prefix
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File include/osmocom/hnbgw/cnlink.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40263/comment/605bd622_02101b84?u… :
PS2, Line 96: hnbgw_cnlink_term_and_free
Yes because it was missing, and since I'm cleaning
up the name of the function I'm also taking the c […]
(not willing to block
here, but) why not adding it in the patch that actually needs this function...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40263?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: If20890bb99885e8c18732588376f8fdaa326d639
Gerrit-Change-Number: 40263
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 12 May 2025 07:25:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>