Attention is currently required from: laforge, pespin, fixeria, daniel.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31903 )
Change subject: select.c: osmo_fd_unregister(): Avoid assert hit with old buggy users of the API
......................................................................
Patch Set 2:
(1 comment)
File src/core/select.c:
https://gerrit.osmocom.org/c/libosmocore/+/31903/comment/a7ce13d0_a4a68bb1
PS2, Line 234: fprintf(stderr, "osmo_fd_unregister(fd=%u) out of expected range (0..%u), fix your code!!!\n",
why printf and not an osmocom error log message?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31903
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If77b84d603a42a216d550d9708eb62f645634a61
Gerrit-Change-Number: 31903
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Comment-Date: Tue, 14 Mar 2023 11:23:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment