[M] Change in libosmocore[master]: libosmogsm: Factor out the C2 derivation function

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33092 ) Change subject: libosmogsm: Factor out the C2 derivation function ...................................................................... Patch Set 4: (2 comments) File src/gsm/auth_core.c: https://gerrit.osmocom.org/c/libosmocore/+/33092/comment/0237ede1_29c4a45e PS4, Line 364: param[in] missing param name (syntax error), please add `sres_deriv_func` https://gerrit.osmocom.org/c/libosmocore/+/33092/comment/9d3f49fc_1a9c0115 PS4, Line 372: memcpy(xres, res, res_len); maybe do `OSMO_ASSERT(res_len <= sizeof(xres))` before calling `memcpy()`? or do `memcpy(xres, res, OSMO_MIN(res_len, sizeof(xres)))`? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0e7cd55f5578f891cb6cc1b0442920ba5beddae4 Gerrit-Change-Number: 33092 Gerrit-PatchSet: 4 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Comment-Date: Thu, 01 Jun 2023 10:04:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment