11 Oct
2022
11 Oct
'22
11:46 a.m.
Attention is currently required from: pespin, msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29651 )
Change subject: measurement: do not call msgb_l3len without checking ......................................................................
Patch Set 2:
(2 comments)
File src/common/measurement.c:
https://gerrit.osmocom.org/c/osmo-bts/+/29651/comment/bb902927_849f53c3 PS1, Line 920: int l3_len;
That should be usigned. […]
I think the code is more readable when we use the variables.
https://gerrit.osmocom.org/c/osmo-bts/+/29651/comment/023a9241_3c64aa85 PS1, Line 951: l3_len = 0;
l3_len = l3 ? msgb_l3len(msg) : 0;
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29651
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie5a9fe1ba880e68edb74f5f4ca559ac191330d4f
Gerrit-Change-Number: 29651
Gerrit-PatchSet: 2
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: msuraev msuraev@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: msuraev msuraev@sysmocom.de
Gerrit-Comment-Date: Tue, 11 Oct 2022 09:46:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: msuraev msuraev@sysmocom.de
Gerrit-MessageType: comment