Attention is currently required from: fixeria, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27960 )
Change subject: smscb: Store ETWS input state from CBSP
......................................................................
Patch Set 2:
(3 comments)
File src/osmo-bsc/smscb.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/9ddab0d3_bc87afd4
PS1, Line 475: LOG_BTS(bts, DCBS, LOGL_NOTICE, "ETWS PN broadcast voa PCH disabled
(cause=%s)\n",
"via". will fix it.
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/54ad0d68_f4ead073
PS1, Line 510: memcpy(bes->input.sec_info, wrepl->u.emergency.warning_sec_info,
ETWS_SEC_INFO_SIZE);
the 'wrepl' is something that the CBSP decoder
of libosmogsm passes to us, not a raw msbb structure […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/e99ee403_01eee9c2
PS1, Line 705: osmo_timer_del(&bts->etws.timer);
thanks. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27960
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ide74638880d7e3c6a7c774bf6320d3dce4b11c74
Gerrit-Change-Number: 27960
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Apr 2022 20:49:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment