Attention is currently required from: Pablo Neira Ayuso, neels, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libgtpnl/+/26990
)
Change subject: fix some cases of rc == 0 on error
......................................................................
Patch Set 1:
(1 comment)
File src/gtp-genl.c:
https://gerrit.osmocom.org/c/libgtpnl/+/26990/comment/115394b2_d0f7dd4c
PS1, Line 82: return -2;
why the magic number "-2"? Why not simlpy
do "rc = genl_socket_talk()" and then pass that 'rc' valu […]
or
perhaps:
rc = -errno;
perror();
return rc;
--
To view, visit
https://gerrit.osmocom.org/c/libgtpnl/+/26990
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I22fd69709e023572c6c616a4184340a554456faf
Gerrit-Change-Number: 26990
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pablo Neira Ayuso <pablo(a)gnumonks.org>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Pablo Neira Ayuso <pablo(a)gnumonks.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 31 Jan 2022 16:24:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment