Attention is currently required from: osmith, laforge.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31025 )
Change subject: Introduce tundev API
......................................................................
Patch Set 7:
(2 comments)
File src/core/tun.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2932):
https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/45d51848_66fe7179
PS7, Line 370: if (tb[IFLA_MTU]) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2932):
https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/623804e4_24f6ac56
PS7, Line 823: #if 1
Consider removing the #if 1 and its #endif
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31025
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3463271666df1e85746fb7b06ec45a17024b8c53
Gerrit-Change-Number: 31025
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 23 Jan 2023 13:39:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment