Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249 )
Change subject: subscr_conn_fsm: refactor timeouts
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bsc-nat/bsc_nat.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249/comment/6652222c_caac6cf1
PS2, Line 31: struct osmo_tdef g_bsc_nat_tdefs[] = {
Done
set to static. Using static const seems
wrong, osmo_tdefs_reset() changes it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: Ib34e6ccc34901ebc37d2dbe347d9644cb70921ca
Gerrit-Change-Number: 28249
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jun 2022 10:00:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment