Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email )
Change subject: HTTP_Adapter: allow API users to specifiy custom header ......................................................................
Patch Set 1:
(4 comments)
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/fa87a4c6_ed625... PS1, Line 41: function ts_HTTP_Header(template charstring body := omit, I'd prefer having this one prefixed "f_ts_", since it's actually a function. Furthermore, this is a ts_ template, so it makes no sense to receive a "template charstring". It should be at least "template (omit) charstring".
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/c144563b_a13d3... PS1, Line 42: template charstring host := omit, template (omit) charstring
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/79f1158b_02fef... PS1, Line 55: if (ispresent(body)) { I'm not sure ispresent() can be used this way, or only for optional fields in a record. You probably need "istemplatekind". Make sure ispresent() doesn't return always true here.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/0d028e9e_752b2... PS1, Line 59: /* Add custom header lines, already existing headers (name) are updated */ I think it makes sense to move this to a separate function "merge_headers()" or "overlay_headers()". This way the test can also simply get the regular header and call that function.