Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39076?usp=email )
Change subject: s1gw: make f_ConnHdlr_rx_session_modify_req() more flexible ......................................................................
Patch Set 1:
(1 comment)
File s1gw/S1GW_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39076/comment/24099919_22cde... : PS1, Line 739: far_id := 1);
FAR ID is not specific to an E-RAB. Each E-RAB has two FAR IDs, it's always 1 and 2. […]
isn't far ids being 1 and 2 just an implementation detail on how the node works? It could be any number right? May be worth properly documenting that with a constant or whatever, or also manage it as a param as mentioned.