23 Feb
2026
23 Feb
'26
11:54 a.m.
Attention is currently required from: Hoernchen.
lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42179?usp=email )
Change subject: dfu: make resp buffer static ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File usb/class/dfu/device/dfudf.c:
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42179/comment/c2e20dad_e8f7d225... : PS1, Line 156: static uint8_t response[6]; // static: usbdc_xfer stores a pointer for async DMA It should copy it over because this transfer is smaller 8, so no DMA.
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42179?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I2f9336143190350817e6352b00751b35b1600b62
Gerrit-Change-Number: 42179
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus lynxis@fe80.eu
Gerrit-Attention: Hoernchen ewild@sysmocom.de
Gerrit-Comment-Date: Mon, 23 Feb 2026 10:54:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes