Attention is currently required from: pespin, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30978 )
Change subject: layer23: Move layer2-socket VTY command to common/ ......................................................................
Patch Set 1:
(6 comments)
File src/host/layer23/include/osmocom/bb/common/vty.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/13164637_2d1dc039 PS1, Line 25: extern bool l23_vty_reading; adding l23_vty_reading seems unrelated to the move. separate patch?
File src/host/layer23/src/common/main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/1aa2530f_a3f4d3bc PS1, Line 166: layer2_socket_path = optarg; are you sure about changing the allocation here? seems unrelated to the code moved, separate patch?
https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/e74e04ca_2928ed3c PS1, Line 292: rc = layer2_open(ms, ms->settings.layer2_socket_path); this seems like a bugfix unrelated to the move. ms->settings.layer2_socket_path existed before this patch, but this code here failed to use it?
File src/host/layer23/src/common/vty.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/0a0c85de_46772434 PS1, Line 53: static void l23_vty_restart(struct vty *vty, struct osmocom_ms *ms)
I'm just keeping the old name here, adding the new prefix.
(a different name would be good indeed, but rather no additional changes during a patch that moves things)
https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/f9984493_198e4759 PS1, Line 168: /tmp/osmocom_l2 "Unix socket, default '" L2_DEFAULT_SOCKET_PATH "'"
https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/880160ab_31ea8449 PS1, Line 243: /* placeholder for shared VTY commands */ the empty function was a placeholder, now it is used and no longer a placeholder