Attention is currently required from: pespin, msuraev.

View Change

6 comments:

• File src/host/layer23/include/osmocom/bb/common/vty.h:

  • Patch Set #1, Line 25: extern bool l23_vty_reading;

    adding l23_vty_reading seems unrelated to the move. separate patch?

• File src/host/layer23/src/common/main.c:

  • Patch Set #1, Line 166: layer2_socket_path = optarg;

    are you sure about changing the allocation here?
    seems unrelated to the code moved, separate patch?

  • Patch Set #1, Line 292: rc = layer2_open(ms, ms->settings.layer2_socket_path);

    this seems like a bugfix unrelated to the move. ms->settings.layer2_socket_path existed before this patch, but this code here failed to use it?

• File src/host/layer23/src/common/vty.c:

  • Patch Set #1, Line 53: static void l23_vty_restart(struct vty *vty, struct osmocom_ms *ms)

    I'm just keeping the old name here, adding the new prefix.

    (a different name would be good indeed, but rather no additional changes during a patch that moves things)

  • Patch Set #1, Line 168: /tmp/osmocom_l2

    "Unix socket, default '" L2_DEFAULT_SOCKET_PATH "'"

  • Patch Set #1, Line 243: /* placeholder for shared VTY commands */

    the empty function was a placeholder, now it is used and no longer a placeholder

To view, visit change 30978. To unsubscribe, or for help writing mail filters, visit settings.