Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 )
Change subject: WIP: vty: Add check against sensible default value for ny1 ......................................................................
Patch Set 3:
(2 comments)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/e7c228ae_3f297887 PS1, Line 535: unsigned long ny1;
I didn't want to move those lines into the function, because @bts. […]
It's totally fine to include logging in bts.c :)
File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/c6ec3efa_fa01d039 PS1, Line 96: unsigned long ny1;
I thought reconfiguration of Ny1 during runtime might be a scenario which is why I added both checks […]
ACK, feel free to leave it there then.