Attention is currently required from: Timur Davydov, fixeria, laforge.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email )
Change subject: transceiver: return -EINVAL for invalid SETSLOT ......................................................................
Patch Set 2: -Code-Review
(1 comment)
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42421/comment/4d08d05f_dbe75b31?usp=... : PS1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */
`ctrl_cmd_handle()` is introduced in the following commit. […]
After looking at the follow up commit, I also understand now what @vyanitskiy@sysmocom.de means.
Since I think we should be answering the failed SETSLOT, I think it's actually good to return 0 because then in your next patch it won't be skipped and it will be answered.
So I think this commit should be dropped and your other patch will "for free" fix this issue.