Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/39690?usp=email )
Change subject: sccp: Allow marking UNIT-DATA.req Sequence Control param non-presence, set
SLS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
FYI: All users of SCCP UNIT-DATA.req (through osmo_sccp_tx_unitdata(_msg)()) are using it
to send RESET/RESET-ACK and PAGING messages, so it's fine to set the
OSMO_SCU_UNITDATA_REQ_P_SEQUENCE_CONTROL_NOT_PRESENT in osmo_sccp_tx_unitdata() so they
end up as ProtoClass 0 imho.
I used the NOT_PRESENT define in order to avoid breaking ABI, let me know if you think I
should be adding a "bool in_seq_control_present" instead.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/39690?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I834e91c1ec337713b0e684cf4fd7de854150bef6
Gerrit-Change-Number: 39690
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 04 Mar 2025 20:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No