laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26829 )
Change subject: icE1usb fw: Set wDetachTimeout to 0 in DFU descriptor ......................................................................
icE1usb fw: Set wDetachTimeout to 0 in DFU descriptor
It was pointed out that this should be 0 since we trigger detach ourselves, we don't need a bus reset.
Signed-off-by: Sylvain Munaut tnt@246tNt.com Change-Id: Id7051ce00863c03e3498f4bab0a7124938e197c0 --- M firmware/ice40-riscv/icE1usb/usb_desc_app.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
diff --git a/firmware/ice40-riscv/icE1usb/usb_desc_app.c b/firmware/ice40-riscv/icE1usb/usb_desc_app.c index 886181c..246e70f 100644 --- a/firmware/ice40-riscv/icE1usb/usb_desc_app.c +++ b/firmware/ice40-riscv/icE1usb/usb_desc_app.c @@ -230,7 +230,7 @@ .bLength = sizeof(struct usb_dfu_func_desc), .bDescriptorType = USB_DFU_DT_FUNC, .bmAttributes = 0x0d, - .wDetachTimeOut = 1000, + .wDetachTimeOut = 0, .wTransferSize = 4096, .bcdDFUVersion = 0x0101, },