Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630 )
Change subject: library/RAN_Emulation: testcase.stop -> mtc.stop
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
It should be said that I definitely don't want to
force using `f_shutdown` everywhere, especially us […]
On the other hand, I find
this `Stopping testcase execution from ...` logging very useful when investigating various
issues. All in all, I am fine with this patch as it as, but would also welcome doing
`setverdict(fail, ...); Misc_Helpers.f_shutdown(__BFILE__, __LINE__)`.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8923975f6cb48f5f628e2ac5dc412f0f3ab97aab
Gerrit-Change-Number: 33630
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Jul 2023 13:39:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment