Attention is currently required from: fixeria.
daniel has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38882?usp=email )
Change subject: Osmocom_CTRL_Functions.ttcn: Use Misc_Helpers.f_shutdown() everywhere
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File library/Osmocom_CTRL_Functions.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38882/comment/0fb3ea42_909e…
:
PS2, Line 47: log2str
I don't like using `f_shutdown()` for setting the
testcase verdict, so no CR+1 from me, sorry.
What's the reason there? Because it
gets in the way of searching for setverdict() in the code?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38882?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3b11a4dee35da89b2fec0cc66021dd57db04beb4
Gerrit-Change-Number: 38882
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Nov 2024 16:34:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>