Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32320 )
Change subject: sccp_scoc.c: fix infinite loop on conn ID exhaustion ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sccp/+/32320/comment/d896afc4_020b7255 PS1, Line 17: entire SCCP conn id number space before exiting in failure.
I don't think it should be configurable. […]
Ack
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/32320/comment/9f89bd49_72508cf8 PS1, Line 551: if (!max_attempts || max_attempts > 0x00FFFFFE) { I really see no much point in having max_attempts configurable as param here, it should simply be set to 0x00FFFFFFFE always and be done with it.
https://gerrit.osmocom.org/c/libosmo-sccp/+/32320/comment/a6537dd7_ccc0c4c2 PS1, Line 589: 0
re above comment: 0 here means always iterate the entire connection ID number space. […]
are you really ever going to pass something other than 0 here?