Attention is currently required from: neels, pespin, fixeria, msuraev.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31415 )
Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993)
......................................................................
Patch Set 8:
(1 comment)
File include/osmocom/gsm/bts_features.h:
https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/e375e6f2_23d7065d
PS7, Line 39: _TX
In a correctly configured setup we should always see the same format in both directions. […]
I now found that there is a BTS variant, so we indeed can distinguish between a sysmo-bts and osmo-bts-trx etc. Ok, then we can go that route.
Changing IPACC would be possible too, but then older osmo-bts versions will not be able to make use of this. Also the old ip.access will not benefit from that.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31415
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043
Gerrit-Change-Number: 31415
Gerrit-PatchSet: 8
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: msuraev
msuraev@sysmocom.de
Gerrit-CC: neels
nhofmeyr@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: msuraev
msuraev@sysmocom.de
Gerrit-Comment-Date: Fri, 10 Mar 2023 11:21:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
nhofmeyr@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: msuraev
msuraev@sysmocom.de
Comment-In-Reply-To: dexter
pmaier@sysmocom.de
Gerrit-MessageType: comment