Change in osmo-bsc[master]: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers)

Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30982 ) Change subject: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers) ...................................................................... Patch Set 3: Code-Review-2 (4 comments) Patchset: PS3: You went the wrong direction by moving that into "neighbor-bts", you need to revert that and go back to version 1. See my inline comments for more info. File src/osmo-bsc/neighbor_ident_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30982/comment/80b91081_3c39d671 PS3, Line 107: struct osmo_strbuf csv = { .buf = log_buf, what does csv stand for? https://gerrit.osmocom.org/c/osmo-bsc/+/30982/comment/7f704224_d0bcee85 PS3, Line 109: .pos = log_buf, grepping for "struct osmo_strbuf" in osmocom code shows all users only set .buf and .len, so the others are probably not needed and just cause noise. https://gerrit.osmocom.org/c/osmo-bsc/+/30982/comment/34d3c3c9_8f43eab3 PS3, Line 118: llist_for_each_entry(n, &bts->neighbors, entry) { This is not correct to my understanding. In here you are only adding to the list neihbours which were defined using the "bts_nr" field. We actually want to to add all neighbors of the BTS regardless of how it was defined. For that, you need to lookup each bts based on the n->type, and take bts->nr. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79aeffd93089086f57c66787fe20b439a4d8b6b4 Gerrit-Change-Number: 30982 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Jan 2023 10:27:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment