Attention is currently required from: arehbein.
Patch set 3:Code-Review -2
4 comments:
Patchset:
You went the wrong direction by moving that into "neighbor-bts", you need to revert that and go back to version 1. See my inline comments for more info.
File src/osmo-bsc/neighbor_ident_ctrl.c:
Patch Set #3, Line 107: struct osmo_strbuf csv = { .buf = log_buf,
what does csv stand for?
Patch Set #3, Line 109: .pos = log_buf,
grepping for "struct osmo_strbuf" in osmocom code shows all users only set .buf and .len, so the others are probably not needed and just cause noise.
Patch Set #3, Line 118: llist_for_each_entry(n, &bts->neighbors, entry) {
This is not correct to my understanding.
In here you are only adding to the list neihbours which were defined using the "bts_nr" field.
We actually want to to add all neighbors of the BTS regardless of how it was defined.
For that, you need to lookup each bts based on the n->type, and take bts->nr.
To view, visit change 30982. To unsubscribe, or for help writing mail filters, visit settings.