Attention is currently required from: fixeria, pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37558?usp=email )
Change subject: codec: add osmo_hr_sid_classify() ......................................................................
Patch Set 2:
(1 comment)
File src/codec/hr_sid_class.c:
https://gerrit.osmocom.org/c/libosmocore/+/37558/comment/3e70872f_cf0295cc PS2, Line 31: static unsigned ones_in_byte(uint8_t byte)
Without testing, we don't know if this built-in function is actually faster than the look-up table a […]
The least powerful BTS CPU we need to support is ARM926EJS on sysmoBTS. That CPU does not have any special instructions that can implement `__builtin_popcount()` with native efficiency, hence I prefer the table approach recommended by Vadim - it will probably be more efficient than whatever gcc will generate.