14 Mar
2023
14 Mar
'23
10:25 p.m.
Attention is currently required from: osmith, laforge, fixeria, daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31903 )
Change subject: select.c: osmo_fd_unregister(): Avoid assert hit with old buggy users of the API ......................................................................
Patch Set 2:
(1 comment)
File src/core/select.c:
https://gerrit.osmocom.org/c/libosmocore/+/31903/comment/0d50a809_59f62352 PS2, Line 234: fprintf(stderr, "osmo_fd_unregister(fd=%u) out of expected range (0..%u), fix your code!!!\n",
why printf and not an osmocom error log message?
I didn't find any osmocom log function here, only fprintf, so I assumed we want to keep osmo_log outside of all this low level code.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31903
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If77b84d603a42a216d550d9708eb62f645634a61
Gerrit-Change-Number: 31903
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Tue, 14 Mar 2023 11:25:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de
Gerrit-MessageType: comment