Attention is currently required from: laforge, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31687 )
Change subject: pcu_sock: only allow Ericsson RBS to connect to external PCU ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31687/comment/c32a08e7_0582af2c PS2, Line 964: return -EINVAL;
Thanks. […]
What are you doing? My concern was that there is already a message being printed (by the VTY code), but it does not say *what exactly is wrong*. It might not be obvious to the user/operator that only Ericsson RBS is supported, so we should make this clear in the logging message. See below: "Could not create unix socket", "Could not register listen"...