Attention is currently required from: dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/29650
)
Change subject: l1sap: do not call msgb_l2hlen without checking
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/29650/comment/490592b3_75600412
PS1, Line 352: *len = 0;
Much more concise this way:
*len = msgb_l2(msg) ? msgb_l2len(msg) : 0;
https://gerrit.osmocom.org/c/osmo-bts/+/29650/comment/30ca2ab8_77233a3d
PS1, Line 396: *len = 0;
Same
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/29650
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie13d0724f183ff240714dcdbd24e5a21b4276bfe
Gerrit-Change-Number: 29650
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Oct 2022 16:39:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment