Attention is currently required from: lynxis lazus, pespin.
neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email )
Change subject: vlr: add PS support ......................................................................
Patch Set 11: Code-Review+1
(2 comments)
File src/libvlr/vlr_lu_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/e1e4ace2_3f96afae?usp=... : PS5, Line 771: /*! count times timer T timed out */
i will veto block this patch unless you make this: […]
Done
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/ad13d0c6_28e46fc5?usp=... : PS5, Line 1611: fi->T
(Nearly) All of the timers used in the VLR are different between CS and PS. […]
yes but my point is:
any program using a VLR is only CS or PS, never both CS *and* PS. So I would expect that a PS program simply uses the PS timers, and does not need to also pass the CS timers as argument all the time, because, the entire program does never need CS timer values. Right?