Attention is currently required from: neels, arehbein, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 )
Change subject: vty: Add check against sensible default value for Ny1 ......................................................................
Patch Set 16:
(3 comments)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/6787ab5e_9bb9fd01 PS14, Line 1725: otherwise return a suggestion for Ny1
this is still not true
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/a4f75966_616bef2b PS14, Line 1726: the message to print
this also needs to be updated, I guess (I see no msg argument)
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/776c4ccc_2770d66e PS14, Line 1738: unsigned long T3105 = osmo_tdef_get(bts->network->T_defs, 3105, OSMO_TDEF_MS, -1);
in osmocom style we are required to declare all variables at the top of the scope
Huh, I don't see such a requirement in https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards#C.... Likely something we agreed on verbally?