Change in osmo-hlr[master]: Add vty `imsi unknown cause` to set the reject cause

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `imsi unknown cause` to set the reject cause ...................................................................... Patch Set 6: Code-Review-1 (2 comments) Patchset: PS6: CR-1 for incomplete command description. Try running osmo-hlr with this patch, enter the VTY interface and check help ('?') for all components of the new command. You should see something like this: OsmoHLR(config-hlr)# imsi? Define the GSUP cause to be send in case the IMSI could not found in the database. OsmoHLR(config-hlr)# imsi unknown? Default is imsi-unknown. OsmoHLR(config-hlr)# imsi unknown cause? NULL OsmoHLR(config-hlr)# imsi unknown cause ? NULL I am surprised why Jenkins does not catch this. Usually it does. File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/95854688_b8539486 PS6, Line 381: imsi unknown cause Here I would recommend concatenating all three words using '-', i.e. 'imsi-unknown-cause'. Otherwise the VTY engine requires you to provide help strings for each separate word in the command. Ah, actually I already suggested using 'subscriber-reject-cause' in one of my previous comments. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 25 Mar 2022 08:41:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment