Attention is currently required from: laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/33110 )
Change subject: modem: do not send RTS.ind if we got PTCCH/D
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/host/layer23/src/modem/rlcmac.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/33110/comment/ed55177d_31200b00
PS1, Line 187: if (fn % 104 == 12)
: return 0;
would make sense to use that #define from two patches
eariler... […]
Yeah, this is not that easy to do. Ideally, we should move this to
libosmocore (`<osmocom/gsm/gsm0502.h>`) so that osmo-{bts,pcu} could reuse these
constants/macros, but for now I would prefer to merge this as-is.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/33110
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Idcdf56de7fc6279d8b942f3670ecdc6f88c3dfd1
Gerrit-Change-Number: 33110
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 07 Jun 2023 15:56:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment