fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28655 )
Change subject: fix incorrect timeout values: milliseconds vs microseconds ......................................................................
fix incorrect timeout values: milliseconds vs microseconds
osmo_timer_schedule() takes (*timer, seconds, microseconds), so the last argument must be in microseconds, not milliseconds.
Change-Id: I1e0b319033415e42ca7f4da9bae348c5cb1da38c --- M src/libosmo-pfcp/pfcp_endpoint.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Jenkins Builder: Verified neels: Looks good to me, approved dexter: Looks good to me, but someone else must approve
diff --git a/src/libosmo-pfcp/pfcp_endpoint.c b/src/libosmo-pfcp/pfcp_endpoint.c index 83b7c1a..e044e75 100644 --- a/src/libosmo-pfcp/pfcp_endpoint.c +++ b/src/libosmo-pfcp/pfcp_endpoint.c @@ -167,7 +167,7 @@ if (!qe->n1_remaining) return false; /* re-schedule timer, keep in queue */ - osmo_timer_schedule(&qe->t1, t1_ms/1000, t1_ms%1000); + osmo_timer_schedule(&qe->t1, t1_ms/1000, (t1_ms % 1000) * 1000); return true; }
@@ -275,7 +275,7 @@ talloc_set_destructor(qe, osmo_pfcp_queue_destructor);
osmo_timer_setup(&qe->t1, pfcp_queue_timer_cb, qe); - osmo_timer_schedule(&qe->t1, timeout/1000, timeout%1000); + osmo_timer_schedule(&qe->t1, timeout/1000, (timeout % 1000) * 1000); return 0; }