Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): use a lookup table for FACCH/H

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27722 ) Change subject: osmo-bts-trx: rx_tchh_fn(): use a lookup table for FACCH/H ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bts-trx/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmo-bts/+/27722/comment/91037f83_2104aef9 PS1, Line 85: int fn_is_odd = (((bi->fn + 26 - 10) % 26) >> 2) & 1; iiuc the "fn_is_odd" before was actually wrong, at least in the naming, since it's no only checking that the fn is odd. It would have been named something like "fn_is_facch" or alike, am I correct? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7c4e3befdd33bef4d89a04a4c7cb1a2d4078c156 Gerrit-Change-Number: 27722 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Apr 2022 09:01:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment