Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/27050 )
Change subject: add osmo_sockaddr_from/to_octets()
......................................................................
Patch Set 1:
(2 comments)
File src/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/27050/comment/18d2a3fc_17796f51
PS1, Line 1746: size_t l;
use len if possible, my eyes hurt seeing number ones everywhere due to l and 1 looking
similar :P
https://gerrit.osmocom.org/c/libosmocore/+/27050/comment/253b2e50_e002e2f3
PS1, Line 1747: switch (os->u.sin.sin_family) {
os->u.sa.sa_family
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/27050
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie9e33bfac525c59c30714663d2bfcc62ec9eeb81
Gerrit-Change-Number: 27050
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Feb 2022 15:45:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment