Change in osmo-pcu[master]: pcu_l1_if_phy: flexible phy access

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31341 ) Change subject: pcu_l1_if_phy: flexible phy access ...................................................................... Patch Set 1: (7 comments) File src/osmo-bts-litecell15/lc15_l1_if.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661): https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/1124e363_1f145ef7 PS1, Line 406: } void function return statements are not generally useful File src/osmo-bts-oc2g/oc2g_l1_if.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661): https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/d39e237a_0b227909 PS1, Line 411: } void function return statements are not generally useful File src/osmo-bts-sysmo/sysmo_l1_if.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661): https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/671c9ec5_cac11734 PS1, Line 388: } void function return statements are not generally useful File src/pcu_l1_if_phy.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661): https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/0a31be9b_9e13f4f0 PS1, Line 7: void *(*l1if_open_pdch)(uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst * gsmtap); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661): https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/86f7fb61_9219ce64 PS1, Line 15: void (*use_phy_cb)(struct l1if_phy * phy), bool solitary); "foo * bar" should be "foo *bar" File src/pcu_l1_if_phy.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661): https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/b0ec1f30_95ce5639 PS1, Line 21: void (*use_phy_cb)(struct l1if_phy * phy); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661): https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/4f8a85ba_1d505c85 PS1, Line 39: void (*use_phy_cb)(struct l1if_phy * phy), bool solitary) "foo * bar" should be "foo *bar" -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8692d1bd5d137a17cf596ee2914722f419c9978d Gerrit-Change-Number: 31341 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 15 Feb 2023 16:06:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment