View Change

7 comments:

• File src/osmo-bts-litecell15/lc15_l1_if.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661):

    Patch Set #1, Line 406: }

    void function return statements are not generally useful

• File src/osmo-bts-oc2g/oc2g_l1_if.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661):

    Patch Set #1, Line 411: }

    void function return statements are not generally useful

• File src/osmo-bts-sysmo/sysmo_l1_if.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661):

    Patch Set #1, Line 388: }

    void function return statements are not generally useful

• File src/pcu_l1_if_phy.h:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661):

    Patch Set #1, Line 7: void *(*l1if_open_pdch)(uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst * gsmtap);

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661):

    Patch Set #1, Line 15: void (*use_phy_cb)(struct l1if_phy * phy), bool solitary);

    "foo * bar" should be "foo *bar"

• File src/pcu_l1_if_phy.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661):

    Patch Set #1, Line 21: void (*use_phy_cb)(struct l1if_phy * phy);

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3661):

    Patch Set #1, Line 39: void (*use_phy_cb)(struct l1if_phy * phy), bool solitary)

    "foo * bar" should be "foo *bar"

To view, visit change 31341. To unsubscribe, or for help writing mail filters, visit settings.