Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email )
Change subject: rspro: use osmo_stream to handle IPA connection ......................................................................
Patch Set 6: Code-Review+1
(2 comments)
File src/rspro_client_fsm.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/39023/comment/5c1fb954_b8edd3af?u... : PS6, Line 174: _ipaccess_bts_handle_ccm It's not the first time I am seeing this (or similar) code. Can we have it in a library somewhere?
https://gerrit.osmocom.org/c/osmo-remsim/+/39023/comment/58a99e96_35190fe6?u... : PS6, Line 226: if (res <= 0) { Is it safe to call `osmo_ipa_msgb_cb_proto()` before this check?