Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30979 )
Change subject: layer23: Let each app allocate its ms obj and start layer2 when needed ......................................................................
Patch Set 3:
(2 comments)
File src/host/layer23/src/misc/app_cell_log.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30979/comment/662ac339_4950d121 PS3, Line 53: fprintf(stderr, "Failed during layer2_open()\n"); It's better to print layer2_socket_path so user know what exactly failed to open. The same applies to all other app_* as well.
File src/host/layer23/src/modem/app_modem.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30979/comment/0a454de6_4add09ee PS3, Line 476: rc = layer2_open(app_data.ms, app_data.ms->settings.layer2_socket_path); This code is duplicated so many times that I can't help but wonder - why not make shared error-printing wrapper for layer2_open() and simply call it from all the app_*?