Attention is currently required from: pespin.

View Change

2 comments:

• File src/host/layer23/src/misc/app_cell_log.c:

  • Patch Set #3, Line 53: fprintf(stderr, "Failed during layer2_open()\n");

    It's better to print layer2_socket_path so user know what exactly failed to open. The same applies to all other app_* as well.

• File src/host/layer23/src/modem/app_modem.c:

  • Patch Set #3, Line 476: rc = layer2_open(app_data.ms, app_data.ms->settings.layer2_socket_path);

    This code is duplicated so many times that I can't help but wonder - why not make shared error-printing wrapper for layer2_open() and simply call it from all the app_*?

To view, visit change 30979. To unsubscribe, or for help writing mail filters, visit settings.