Attention is currently required from: fixeria, jolly, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email )
Change subject: ASCI: Add System Information 10 support
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
This timer to trigger the SI looks a bit hackish, but
I don't know/understand the details here, so l […]
I also don't like the
timer. Who says that 3s is sufficient to establish all the calls? What if there's a
slow (e.g. VSAT) link in between with very high RTT?
The question is what kind of other alternative do we have? And: How hurtful is it if the
timer expires before the MSC has established all of those calls?
File src/osmo-bsc/system_information.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/242086f7_3354ebb9
PS2, Line 1499: /* Do spare padding. We cannot do it earlier, because encoding might
corrupt it if differenctial cell info
differenctial? what do you mean?
the same
"differential cell info" mentioned a few lines above I guess...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3
Gerrit-Change-Number: 34626
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Oct 2023 12:34:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment