Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email )
Change subject: Introduce tests/osmo-config-merge testsuite
......................................................................
Patch Set 4:
(4 comments)
File tests/osmo-config-merge/Makefile.am:
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/0c9de919_e0d9af3e?… :
PS4, Line 25: } >'$(srcdir)/package.m4'
What do we need package. […]
No idea tbh, copied
it from tests/Makefile.am. Let me know if you know better about this stuff.
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/10887003_0c96aef4?… :
PS4, Line 46: [ -e /proc/cpuinfo ] && cat /proc/cpuinfo
This is already done in tests/Makefile.am, so I would
remove it here.
Acknowledged
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/41c61360_43496d27?… :
PS4, Line 47: $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS)
ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS)
```suggestion […]
Acknowledged
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/c125038f_544e472b?… :
PS4, Line 51: $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING)
ENABLE_URING_TESTS=$(ENABLE_URING_TESTS)
```suggestion […]
Acknowledged
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia172d4c280f4bae1b411ad805cca02355ca7fcc9
Gerrit-Change-Number: 40295
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 May 2025 14:27:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>