Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/28485 )
Change subject: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh
resolution cmd
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'm not sure about this one is the proper way to
check for 3digit. […]
There can be 3-digit MNCs starting with 0. MNC=099 is *not*
equal to MNC=99, so I think using strlen() here is better, because
"cgi_ps.rai.lac.plmn.mnc > 99" does not distinguish between MNC=099 and
MNC=99.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/28485
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I819bdb0cc126113542547e9c397673a2dee0f168
Gerrit-Change-Number: 28485
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Jun 2022 17:07:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment