4 Oct
2023
4 Oct
'23
11:40 a.m.
Attention is currently required from: fixeria, jolly, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email )
Change subject: ASCI: Add System Information 10 support
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/e2b372f0_d9e9ada0
PS2, Line 13: For each BTS, an SI 10 is gerated with all other neighbor BTS.
generated
Patchset:
PS2:
This timer to trigger the SI looks a bit hackish, but I don't know/understand the
details here, so letting others provide feedback.
File src/osmo-bsc/system_information.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/b6b504b7_fdbabeb6
PS2, Line 1459: if (c->lchan->ts->trx->bts->c0->arfcn != arfcn)
can we maybe have a "i_bts = c->lchan->ts->trx->bts;" var here to
avoid dereferencing crazy amounts of pointers twice? Also easier to read.
https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/dc130a4f_99adb46a
PS2, Line 1499: /* Do spare padding. We cannot do it earlier, because encoding might
corrupt it if differenctial cell info
differenctial? what do you mean?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3
Gerrit-Change-Number: 34626
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Oct 2023 11:40:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment