30 Aug
2024
30 Aug
'24
6:59 a.m.
Attention is currently required from: dexter, laforge.
fixeria has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/pysim/+/37819?usp=email )
Change subject: Testsuite for pySim-shell with real cards
......................................................................
Patch Set 15:
(2 comments)
File tests/pySim-shell_test/ara_m/test.py:
https://gerrit.osmocom.org/c/pysim/+/37819/comment/432bfaae_35d94fd2?usp=em… :
PS15, Line 27: self.setup(__file__)
Calling this in each test case can be avoided by defining method `setUp` in
`UnittestUtils`. See
https://docs.python.org/3/library/unittest.html#unittest.TestCase.setUp.
https://gerrit.osmocom.org/c/pysim/+/37819/comment/58c7aafc_c33e7283?usp=em… :
PS15, Line 35: self.cleanup()
Likewise, calling this in each test case can be avoided by defining method `tearDown` in
`UnittestUtils`. See
https://docs.python.org/3/library/unittest.html#unittest.TestCase.tearDown.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de
Gerrit-Change-Number: 37819
Gerrit-PatchSet: 15
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Aug 2024 04:59:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No